Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: Add "has-error" class for use with question components (fixes #594) #595

Merged
merged 7 commits into from
Oct 28, 2024
Merged

New: Add "has-error" class for use with question components (fixes #594) #595

merged 7 commits into from
Oct 28, 2024

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented Oct 21, 2024 •
edited
Loading

Fix #594

New

  • Adds the error class has-error to question components when the question cannot be submitted.

Testing

  1. Install and enable Instruction Error which will allow you to submit a question before it is completed (ex. before an option is selected in an MCQ)
  2. Select the "Submit" button before making a choice
  3. The component should now have the has-error class.
  4. Next, make a selection for the question. If the question has multiple items (e.g. Matching), make a selection for every item.
  5. Select the "Submit" button
  6. The has-error class should be removed.

@swashbuck swashbuck added the enhancement New feature or request label Oct 21, 2024
@swashbuck swashbuck self-assigned this Oct 21, 2024
This was referenced Oct 21, 2024
Merged
Open
@kirsty-hames kirsty-hames mentioned this pull request Oct 22, 2024
Merged
kirsty-hames
kirsty-hames approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with #593 and works as expected thanks 👍

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit f45b5bf into master Oct 28, 2024
@oliverfoster oliverfoster deleted the issue/594 branch October 28, 2024 12:37
github-actions bot pushed a commit that referenced this pull request Oct 28, 2024
@semantic-release-bot
Chore(release): 6.60.0
6845bf0 
# [6.60.0](v6.59.0...v6.60.0) (2024-10-28)

### New

* Add "has-error" class for use with question components (fixes #594) (#595) ([f45b5bf](f45b5bf)), closes [#594](#594) [#595](#595)
@oliverfoster
Copy link
Member

🎉 This PR is included in version 6.60.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

Assignees

@swashbuck swashbuck

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add error class to components
4 participants
@swashbuck @oliverfoster @kirsty-hames @cahirodoherty-learningpool